search

grinsfem / grins

Multiphysics Finite Element package built on libMesh
http://grinsfem.github.io
Other
47 stars 39 forks source link

Adding C++11 isms #605

Closed pbauman closed 3 years ago

pbauman commented 3 years ago

Started going down the rabbit hole of adding override last weekend and ended up also going down the rabbit hold of using default in many places, using delete on many of the default constructors we don't want to allow to be used. This led to the "using inherited constructor idiom", removing return; code smells and some whitespace. I did this pretty incrementally, but I couldn't squash all the commits together cleanly and I didn't think it was worth the time to try and go back and do that, so there's a few default keyword and delete keyword commits that aren't squashed.

pbauman commented 3 years ago

Deleted all the unnecessary = delete default constructors (which turned out to be all of them, lol). Squashed in another = default on a destructor and saw a few more inheriting constructors that could be used so dropped those in da6f285; certainly not exhaustive, was just opportunistic.

pbauman commented 3 years ago

Just to clarify, I think this is good to go if you're good with it @roystgnr