Closed vachillo closed 1 month ago
Attention: Patch coverage is 94.28571% with 20 lines in your changes missing coverage. Please review. |
Files with missing lines | Patch % | Lines |
---|---|---|---|
...iptape/drivers/vector/marqo_vector_store_driver.py | 73.33% | 4 Missing :warning: | |
...e/drivers/vector/opensearch_vector_store_driver.py | 71.42% | 2 Missing :warning: | |
...ape/drivers/vector/pinecone_vector_store_driver.py | 77.77% | 2 Missing :warning: | |
...transcription/openai_audio_transcription_driver.py | 83.33% | 1 Missing :warning: | |
...vers/embedding/huggingface_hub_embedding_driver.py | 83.33% | 1 Missing :warning: | |
...generation/azure_openai_image_generation_driver.py | 80.00% | 1 Missing :warning: | |
...image_generation/openai_image_generation_driver.py | 83.33% | 1 Missing :warning: | |
griptape/drivers/sql/amazon_redshift_sql_driver.py | 83.33% | 1 Missing :warning: | |
griptape/drivers/sql/snowflake_sql_driver.py | 83.33% | 1 Missing :warning: | |
...text_to_speech/elevenlabs_text_to_speech_driver.py | 85.71% | 1 Missing :warning: | |
... and 5 more |
:loudspeaker: Thoughts on this report? Let us know!
closes #1174
Describe your changes
This normalizes the usage and naming of API clients in various drivers throughout the framework.
Today, any parameters set after init on any drivers that use a
client
are ignored because theclient
is typically initialized during driver initialization via an attrsFactory
. Adding@lazy_property
to the clients allow for making parameter modifications on theDriver
before the client is used, namely in the globalDefaults
object. see #1174 for an example.Issue ticket number and link
1174