grishka / NearDrop

An unofficial Google Nearby Share/Quick Share app for macOS
The Unlicense
4.5k stars 156 forks source link

Quick Share support? #140

Open Gregman-js opened 10 months ago

Gregman-js commented 10 months ago

Hello Does NearDrop work with the new nearby share implementation, aka Quick Share? My experiments show that no :( For the uninitiated, Google is joining forces with Samsung and introducing alternative in the form of Quick Share. It's rolling out now to supported devices.

My test was trying to share a photo from the Samsung S23 to the MacBook with neardrop v 2.0.2 It works with nearby share, but choosing new unified Quick Share — it doesn't detect MacBook I'm curious how this new application works from the inside and whether it will be possible to implement these protocols here

ubdjshdb commented 10 months ago

It works with nearby share, but choosing new unified Quick Share — it doesn't detect MacBook

From my testing, Nearby Share devices only appear in Samsung Quick Share only after Nearby Share is removed (after a GMS update or a remote config flag?). Tested on S21+/S23 with both NearDrop on Mac and the official app on Windows: they were only showing up in Nearby Share yesterday. Got the update that removed Nearby Share today, now they're showing up in the Samsung app. For non-Samsung devices, I'm pretty sure it's just a rebranding.

Also, this update breaks receiving files from NearDrop on Samsung devices since the Receive files screen is gone (not sure about non-Samsung devices).

grishka commented 10 months ago

update that removed Nearby Share

That's a thing now?!

ubdjshdb commented 10 months ago

update that removed Nearby Share

That's a thing now?!

On Samsung devices, yep. On other phones it rebrands Nearby Share to Quick Share.

Edit: It doesn't completely remove Nearby Share, it merges Nearby Share with Samsung's own file sharing tool.

julianebert commented 10 months ago

+1 After updating Nearby Share to Quick Share on my Pixel 8 Pro, my Macbook Pro with Neardrop doesn't show up in the phone's share menu.

GalacticSenat commented 10 months ago

IT WORKS

jonathandhn commented 10 months ago

It doesn't work with samsung galaxy s23 since the merge, I did not have access to google's nearby share any more only Quick Share

albertonoys commented 10 months ago

Same here thing here on a Galaxy S23.

GalacticSenat commented 10 months ago

Im on s21 Ultra and it works for me, are you guys on newest quickshare version?

albertonoys commented 10 months ago

Im on s21 Ultra and it works for me, are you guys on newest quickshare version?

Yeah, it says I'm on the latest versions:

Quick share: 13.6.11.7 Quick share connectivity: 1.5.02.30 Quick share agent: 3.5.19.23

grishka commented 10 months ago

It doesn't completely remove Nearby Share, it merges Nearby Share with Samsung's own file sharing tool.

The only thing that matters in relation to NearDrop is whether the network protocol is different. Or, at least backwards compatible enough (those version numbers in all packets are there for a reason, after all).

And no, I'm not renaming it to QuickDrop :P

jonathandhn commented 10 months ago

hi @grishka,

So using the QuickShare option to no avail, even with other device (non samsung) using google nearby share. When using another android phone and enabling nearby share discovery, it triggers the google's services pop-up to open the old nearby share.

Using the old nearby share on the samsung s23 (without using the direct share button that has disappeared) allow you to see your mac, but it fails to show a pop-up on the macos side. Moreover, it ended up with multiple time showing duplicated computer (for a same and single mac, with the same and single near drop launched).

Both Xiaomi android 12 and Samsung S23 android 14 now fail to connect to neardrop app, they have changed something on both side, and google nearby share is not actually compatible with Samsung quickshare (even if in the settings of the latter, there is written your samsung account for samsung, your google account for google sharing) as it is not showing android devices on the quickshare menu, and other device sharing with a quickshare enabled device default to google's services. What a mess they have done, it basically means everyone keeps its own tech, but under a single name and a single logo.

grishka commented 10 months ago

but it fails to show a pop-up on the macos side

NearDrop doesn't implement the "device nearby is sharing" popup. Although I suppose I could add it? I reverse engineered that part. It relies on BLE. I can't send the required broadcasts from macOS because of its limited APIs, but there's nothing to prevent me from receiving them.

and google nearby share is not actually compatible with Samsung quickshare

You had one fucking job, Google...

jonathandhn commented 10 months ago

@grishka

but it fails to show a pop-up on the macos side

NearDrop doesn't implement the "device nearby is sharing" popup. Although I suppose I could add it? I reverse engineered that part. It relies on BLE. I can't send the required broadcasts from macOS because of its limited APIs, but there's nothing to prevent me from receiving them.

I mean, when I choose a file to share with my computer, the pop-up to accept the transfer is not showing any more on macOS, nor the device actually findable from QuickShare.

Actually the device is findable from the old Nearby Share Menu on Samsung, And Nearby Share menu on the Xiaomi, but the pop-up to accept the transfer is not showing any more on macOS.

grishka commented 10 months ago

Does it just show up as loading and then fails with a timeout?

jonathandhn commented 10 months ago

On macOS side, nothing, and on android side timeout

https://github.com/grishka/NearDrop/assets/55917666/875709a4-fd81-49b3-a860-c3c27fb289de

https://github.com/grishka/NearDrop/assets/55917666/ea17dd07-760b-4455-bcb3-102f81665cc0

engi2nee commented 9 months ago

Works perfectly for me, using Samsung S24 Ultra with: Quick Share Version 13.6.10.38 Quick Share Connectivity Version 1.5.02.21 Quick Share Agent Version 3.5.19.5

dohun0310 commented 9 months ago

On the Galaxy Z Flip3 I'm using, it doesn't work with 'Quick Share', but it does work with 'Nearby Share'. As you can see in the video below, if I try it on 'Quick Share' it says 'Fail' and I don't even get any notification on my MacBook Pro (Sonoma 14.3), whereas on 'Nearby Share' it works very well. I also moved all the videos below via 'NearDrop' and 'Nearby Share'.

Note If you're not sure if 'Quick Share' and 'Nearby Share' are integrated on your Samsung Galaxy device, check to see if the icons are the same as mine, or long press on 'Quick Share' in the quick panel and a modal will come up telling you they are integrated.

Quick Share Verison: 13.6.11.7 Quick Share Agent Version: 3.5.9.23 Quick Share Connectivity Version: 1.5.02.30 Google Play System Version: November 1, 2023

https://github.com/grishka/NearDrop/assets/63141348/d27dd38f-f215-47cf-bca7-84e8ffe0507c

https://github.com/grishka/NearDrop/assets/63141348/de74798a-f51d-44fc-b247-3068add34195

jonathandhn commented 9 months ago

@dohun0310

On the Galaxy Z Flip3 I'm using, it doesn't work with 'Quick Share', but it does work with 'Nearby Share'. As you can see in the video below, if I try it on 'Quick Share' it says 'Fail' and I don't even get any notification on my MacBook Pro (Sonoma 14.3), whereas on 'Nearby Share' it works very well. I also moved all the videos below via 'NearDrop' and 'Nearby Share'.

Note If you're not sure if 'Quick Share' and 'Nearby Share' are integrated on your Samsung Galaxy device, check to see if the icons are the same as mine, or long press on 'Quick Share' in the quick panel and a modal will come up telling you they are integrated.

Quick Share Verison: 13.6.11.7 Quick Share Agent Version: 3.5.9.23 Quick Share Connectivity Version: 1.5.02.30 Google Play System Version: November 1, 2023

Screen_Recording_20240205_224035_Google.Play.services.mp4

Screen_Recording_20240205_223540_Quick.Share.mp4

But you can see your mac on the device list if QuicShare ? Because mine is not to be found.

As of today @grishka something happened, nearby share seams to work back again with S23, there is something strange going server side I think.

dohun0310 commented 9 months ago

@jonathandhn

@dohun0310

On the Galaxy Z Flip3 I'm using, it doesn't work with 'Quick Share', but it does work with 'Nearby Share'. As you can see in the video below, if I try it on 'Quick Share' it says 'Fail' and I don't even get any notification on my MacBook Pro (Sonoma 14.3), whereas on 'Nearby Share' it works very well. I also moved all the videos below via 'NearDrop' and 'Nearby Share'. Note If you're not sure if 'Quick Share' and 'Nearby Share' are integrated on your Samsung Galaxy device, check to see if the icons are the same as mine, or long press on 'Quick Share' in the quick panel and a modal will come up telling you they are integrated. Quick Share Verison: 13.6.11.7 Quick Share Agent Version: 3.5.9.23 Quick Share Connectivity Version: 1.5.02.30 Google Play System Version: November 1, 2023 Screen_Recording_20240205_224035_Google.Play.services.mp4 Screen_Recording_20240205_223540_Quick.Share.mp4

But you can see your mac on the device list if QuicShare ? Because mine is not to be found.

As of today @grishka something happened, nearby share seams to work back again with S23, there is something strange going server side I think.

Yes, I can see my MacBook even if I use Quick Share. I want to see what happens using XCode, but it's a bit difficult because I don't know how to develop macOS and iOS.

dohun0310 commented 9 months ago

@grishka I am unable to send files via 'NearDrop' anymore because 'Nearby Share' has been completely removed and merged into 'Quick Share' with the installation of One UI 6.1 on Galaxy devices. Upon checking my Galaxy S24 Ultra (running One UI 6.1) using the Files app, I received the following toast message.

'Nearby Share is not available on this device.'

Screenshot_20240206_221528_Files by Google

kineticscreen commented 9 months ago

Unfortunately Google has also removed the "Receive" page from the Files app, so you can't use it to make your phone visible for receiving from NearDrop

NayamAmarshe commented 9 months ago

Google dropped the Receive thing from the Files app. What do we do now? :/

grishka commented 9 months ago

Google dropped the Receive thing from the Files app. What do we do now? :/

Oops. Make an intent shortcut like it says in readme then. Unless they removed that activity as well.

dohun0310 commented 9 months ago

Google dropped the Receive thing from the Files app. What do we do now? :/

Oops. Make in intent shortcut like it says in readme then. Unless they removed that activity as well.

They started to remove that activity in gms

grishka commented 9 months ago

That's extremely unfortunate. But then maybe they added some new way to enable the MDNS service that doesn't involve sending impossible BLE advertisements. This needs further research.

mitesh77 commented 9 months ago

I am unable to send files via 'NearDrop' anymore because 'Nearby Share' has been completely removed and merged into 'Quick Share' with using google Files app, I am using google Pixel 8 pro now not working at all we don't have any Receive Button so how we fixed?

mitesh77 commented 9 months ago

@grishka I think at the moment the best solution is to keep the old Google Files app apk, installation takes a few seconds and then open and use It.

another solution is we can just clean the storage and cache whenever mac to sends Android file share.

https://github.com/grishka/NearDrop/assets/38649435/238f94b9-b61c-45e1-8971-419438d2356a

https://github.com/grishka/NearDrop/assets/38649435/40642320-2ced-4781-8984-6d3b7200de3b

it is not appropriate for the long term but is Ok for now.

stanleylhs commented 9 months ago

@mitesh77 Which version should we install to get the receive tab back?

TheOnlineUser commented 9 months ago

@grishka I think at the moment the best solution is to keep the old Google Files app apk, installation takes a few seconds and then open and use It.

This doesn't work, unfortunately (I have a Galaxy S23 Ultra). I downgraded to the January 22, 2024 version of Google Files, which still has the Nearby Share tab…but when I click "Receive," it says "Nearby sharing isn't available on this device."

I can use Quick Share on the Samsung phone to send files to the Mac, but when I select a file > Share > NearDrop > NearDrop's share screen opens, it never detects my Samsung phone.

souljedi commented 9 months ago

Maybe the following works for some of you as well (as a workaround):

In the Google Play Store, navigate to Google Files and then select "Uninstall". This will not remove Google Files but it will uninstall all updates to it. Afterwards, I got the Nearby receive tab again. Furthermore, you can disable automatic updates for that package, until hopefully a new solution is found.

mitesh77 commented 9 months ago

@stanleylhs latest one but not sure how many days will work.

TheOnlineUser commented 9 months ago

Maybe the following works for some of you as well (as a workaround):

In the Google Play Store, navigate to Google Files and then select "Uninstall". This will not remove Google Files but it will uninstall all updates to it. Afterwards, I got the Nearby receive tab again. Furthermore, you can disable automatic updates for that package, until hopefully a new solution is found.

This won't work for any Samsung users, who don't have Google Files installed by default. I uninstalled from the Play Store and it removed it completely. As noted in my prior comment, even installing an older version with Nearby Share doesn't work because the framework on Samsung phones has been removed.

Gregman-js commented 9 months ago

I can confirm that on my S23+ after February update and Nearby Share removal - Quick Share can send files to NearDrop. So probably Quick Share use same protocol for non Samsung devices under the hood as Nearby Share. Question is now how we can receive files on phone via Quick Share

eugenekv commented 9 months ago

After the update on my s22 Nearby Share also disappeared and when I'm trying to share something with Quick Share the app doesn't see my Mac despite turning on Bluetooth and connection to the same wifi network. Same situation, but it works with Flip 3 but it is searching for the device for a really long time

harshbharadwaj07 commented 9 months ago

Got a temporary workaround which involves uninstalling the updates for Google Play Services and Quick Share from phone's settings. This works for me atleast for now.

dohun0310 commented 9 months ago

I change my phone Galaxy Z Filp3 to Pixel 6 Pro. Everything is work. My Pixel 6 Pro still alive com.google.android.gms/.nearby.sharing.ReceiveSurfaceActivity activity.

eugenekv commented 9 months ago

It's working again after yesterday's update of apps in GP

After the update on my s22 Nearby Share also disappeared and when I'm trying to share something with Quick Share the app doesn't see my Mac despite turning on Bluetooth and connection to the same wifi network. Same situation, but it works with Flip 3 but it is searching for the device for a really long time

NayamAmarshe commented 9 months ago

It seems like they brought back nearby share in the latest files update.

grishka commented 9 months ago

Sending works just fine for me. The UI is entirely different but the protocol appears to have remained the same, or at least backwards compatible. Screenshot_20240219-135634

TropicolX commented 9 months ago

Got a temporary workaround which involves uninstalling the updates for Google Play Services and Quick Share from phone's settings. This works for me atleast for now.

This also works for me on my S21 Ultra

TheOnlineUser commented 9 months ago

Sending works just fine for me. The UI is entirely different but the protocol appears to have remained the same, or at least backwards compatible.

Sending (to macOS) works for most of us. It's receiving (from macOS to Android) that is seemingly broken.

grishka commented 9 months ago

As I already said before, the problem with macOS -> Android is that to become discoverable, Android expects BLE advertisements that are impossible to send using any macOS APIs I tried, both public and private. The "service data" field in particular can't be specified, but Android requires it to be present and its value to match a hardcoded prefix. If someone smarter than me would find a way to do it, I'll be more than happy to add it to the app. Or, if someone finds an alternative I may have overlooked while looking through a decompiled Google Services apk.

That "open Google Files" thing is just a gross workaround for being unable to send that BLE advertisement.

osenvosem commented 9 months ago

Samsung s23 Ultra. Nearby Share is removed for now and Quick share doesn't see Macbook.

makerjeff commented 9 months ago

I have a Samsung Note 10+, and my 2020 M1 Macbook Air doesn't show up under Quick Share's "Share to devices nearby" section.

Nearby Share + NearDrop was working flawlessly up until yesterday. How would I go about uninstalling Quick Share from the updates as a temporary workaround?

harshbharadwaj07 commented 9 months ago

Got a temporary workaround which involves uninstalling the updates for Google Play Services and Quick Share from phone's settings. This works for me atleast for now.

@makerjeff check it once

harpality commented 9 months ago

Updated to QuickShare on Pixel 8 today. Neardrop seems to work fine from Android -> macOS as usual. I didn't know the reverse was possible before, so never tried it.

Wonder if any thoughts about renaming NearDrop to QuickDrop to match the brand change.

grishka commented 9 months ago

Wonder if any thoughts about renaming NearDrop to QuickDrop to match the brand change.

No, I'm not Google. I don't change my mind on things 5 times a year for no good reason.

harpality commented 9 months ago

Wonder if any thoughts about renaming NearDrop to QuickDrop to match the brand change.

No, I'm not Google. I don't change my mind on things 5 times a year for no good reason.

lol fair

AndreiRegiani commented 9 months ago

Doesn't work anymore for me: Galaxy S23 Ultra, February 1 2024 -> macOS M1 Pro using Quick Share since NearbyShare is gone.

Mac is found but transfer fails.

grishka commented 9 months ago

Most problems seem to be with Samsung devices but I don't have a Samsung device that still receives updates to test this ¯\_(ツ)_/¯

Still works with my Pixel 4a.