grishka / NearDrop

An unofficial Google Nearby Share/Quick Share app for macOS
The Unlicense
4.49k stars 156 forks source link

Communication error: Transferring files from Samsung to Mac by using Quick Share #156

Closed RokGis closed 6 months ago

RokGis commented 7 months ago

Transferring from Samsung Galaxy S24 Ultra to MacBook Pro M3 using Quick Share worked fine until this week. Now, anytime I try, the Mac shows this error. However, transferring from Samsung Galaxy Tab S9+ to Mac still works.

image
MikaSon1 commented 7 months ago

Thanks RokGis,

I am experiencing the same issue as you are with my S24U and MacBook Pro M1. They both stopped working and show the same error message. I appreciate you for raising this issue on GitHub, and I want to thank Grishka in advance for fixing it :)

kokasaurus commented 7 months ago

Can confirm that this is happening. My S24 Ultra and S24+ are having the same issue, but my other phones do not have this problem. No idea what caused the issue though.

muhep06 commented 7 months ago

My Mac doesn't even show up in the list.

GalacticSenat commented 7 months ago

same thing for me, always worked till recently (S21 ultra)

bartick commented 7 months ago

Just downloaded the app and same thing with me (S20 FE)

themoonboy-09 commented 7 months ago

I have the same issue with my Pixel 8 Pro and my M2 Max MBP (macOS Sonoma 14.4.1) with the 2.0.2 & 2.0.1 of NearDrop.

Screenshot 2024-04-19 at 09 40 40

spanzifull commented 7 months ago

Same for me, mac M1 with Sonoma 14.4.1 (23E224) and Galaxy S24 Ultra

AgrMayank commented 7 months ago

+1 Seems like something is broken in between after the rebrand :(

kohpai commented 7 months ago

Same problem, same notification here

KhunHtetzNaing commented 7 months ago

Same on Galaxy 23 and M2 Pro Max Sonoma 14.4.1

rickymohk commented 7 months ago

Recently get this error with Pixel 8 and Google Play Services 24.15.58. Another phone with Google Play Services 24.15.18 sees no issue. So I unsubscribe beta program of Google Play Services, uninstall and reinstall updates of Google Play Services. Somehow I still got 24.15.58 (maybe it is already rolling out), but NearDrop works again.

nintendork07 commented 7 months ago

it works fine for me on my galaxy s23 & m1 macbook air. when you share, you have to press the quick share icon, then afterwards it will just pop up like other devices do.

muhep06 commented 7 months ago

In the meantime, it has started to work. I was able to successfully send files from my phone to my Mac. I think Google fixed something.

bartick commented 7 months ago

it works fine for me on my galaxy s23 & m1 macbook air. when you share, you have to press the quick share icon, it won't just pop up like other devices do, it's available under the "share to devices nearby" section.

It just shows up as connecting. Then no pop up shows on mac and it fails to send files. (Using s20 fe & m1) What are the settings I should look into? I believe I have done every settings.

nintendork07 commented 7 months ago

this is what shows up for me. it shows up as a regular device now too once you share once. this is on my s20+

Screenshot_20240429_024106_Android System Screenshot_20240429_024048_Quick Share

rickymohk commented 7 months ago

Guys please note that discovery issue is off-topic. This thread is about communication error after sharing.

thewookiewon commented 6 months ago

Same for me, get the notification but it disappears instantly on macOS Sonoma 14.4.1 sending from my S24 Ultra

dxmahx commented 6 months ago

In the meantime, it has started to work. I was able to successfully send files from my phone to my Mac. I think Google fixed something.

Unfortunately it still doesn't work for me

Zipple44 commented 6 months ago

I am receiving the same "communication Error" as others. I was able to use 3 months ago. Using Sonoma 14.4.1. Help, help, help......

freddie-freeloader commented 6 months ago

⚠️ ⚠️ ⚠️ PLEASE READ ⚠️ ⚠️ ⚠️

If you

There is no point in flooding this thread & repository with comments -- it will just annoy the maintainer.

Note: You might try KDE Connect as an alternative in the meantime.

MobileSam commented 6 months ago

I did a little bit of digging and was able to find out that the protobuf file wire_format.proto seems to be out of date.

Location_Nearby_Connections_V1Frame receives a frame type with the rawValue of 12 which is not defined in the definition file I was able to find.

My (really bad not a proper solution) fix is to handle rawValue 12 as unknownFrameType After that, everything worked correctly and I received the file on my Mac without any other issues. If someone can find the updated protobuf files we should be able to fix this issue properly

DayDreamingTime commented 6 months ago

I did a little bit of digging and was able to find out that the protobuf file wire_format.proto seems to be out of date.

Location_Nearby_Connections_V1Frame receives a frame type with the rawValue of 12 which is not defined in the definition file I was able to find.

My (really bad not a proper solution) fix is to handle rawValue 12 as unknownFrameType After that, everything worked correctly and I received the file on my Mac without any other issues. If someone can find the updated protobuf files we should be able to fix this issue properly

Any chance you could rephrase this in words that a lay person could understand....please.

bartick commented 6 months ago

I did a little bit of digging and was able to find out that the protobuf file wire_format.proto seems to be out of date. Location_Nearby_Connections_V1Frame receives a frame type with the rawValue of 12 which is not defined in the definition file I was able to find. My (really bad not a proper solution) fix is to handle rawValue 12 as unknownFrameType After that, everything worked correctly and I received the file on my Mac without any other issues. If someone can find the updated protobuf files we should be able to fix this issue properly

Any chance you could rephrase this in words that a lay person could understand....please.

@DayDreamingTime He is just saying that there is a data transfer format that was changed by google. Which is out of date for this code and needs to be updated for fixing this connection issue.

DayDreamingTime commented 6 months ago

Which I guess means that that's something the App developer (Grishka) needs to do and not something that I can do. I am so frustrated about how difficult it is to transfer images from my Samsung phone to my Macbook Pro....I really was enjoying how easy NearDrop was after making myself half crazy with Dex for years.

bartick commented 6 months ago

@MobileSam Hey Sam thank you for your input. I did some digging and got this protobuf file from google's repo https://github.com/google/nearby/blob/44725985088d0afa3ae6ac0246cce5bf553e5c5c/sharing/proto/wire_format.proto

I hope this is the correct file and would really appreciate if you could fix the protocol buffer issue.

I am not entirely familiar with swift and we are unsure when the library maintainer will get some time to address the issue. I am hoping if someone opens a proper fix PR the maintainer will approve them.

MobileSam commented 6 months ago

Hey @bartick I'm sorry but this file is also out of date. You can see on line 195 that the FrameType enum stops at 7. We would need the one where it goes up to 12 or at least reference 12.

I can submit a PR that would treat any unknown value as unknownFrameType to at least open the discussion with the maintainer.

Aditya1349 commented 6 months ago

Now i am getting same "communication error" problem while transferring from my S21 FE to my MacBook Air. I think it needs an update i guess.

DayDreamingTime commented 6 months ago

Thank you!!!!! It's back and working again. I am so grateful for all the work that you do.