grishka / Smithereen

Federated, ActivityPub-compatible social network server with friends, walls, and groups.
The Unlicense
385 stars 30 forks source link

[GoToSocial] Can't follow account #77

Closed SadmL closed 1 month ago

SadmL commented 1 month ago

Account looks like locked, but in fact it's not

GoToSocial изображение

Mastodon изображение

grishka commented 1 month ago

GoToSocial probably expects "manuallyApprovesFollowers": false and assumes true if it's not present. I'll add that field to my actors.

You should still be able to follow Smithereen accounts, it'll just look like you sent a follow request that was instantly accepted (which is how following works in ActivityPub anyway).

grishka commented 1 month ago

This change should now be live on friends.grishka.me

SadmL commented 1 month ago

Looks like it's not

You should still be able to follow Smithereen accounts, it'll just look like you sent a follow request that was instantly accepted (which is how following works in ActivityPub anyway).

Mastodon home timeline: 24-08-2024_03-34

GoToSocial home timeline: изображение

But follow request was sent изображение

I was able to find this post via URL, but it not shown in timeline изображение

SadmL commented 1 month ago

Also tried phone app - account still shown as locked Screenshot_20240824-154743_Moshidon

grishka commented 1 month ago

I don't know how it works for GoToSocial, but you need to make it reload the actor object somehow. On Mastodon this can be done by pasting the origin URL (https://friends.grishka.me/danilax86) into the search.

SadmL commented 1 month ago

Posts import counts as actor object reload? I asking this, because I can import post via URL, but there is no refresh for account itself.

grishka commented 1 month ago

No, importing a post doesn't usually reload the actor

SadmL commented 1 month ago

I'll manage it somehow, I guess...

SadmL commented 1 month ago

Good news: account looks like no more locked Bad news: still shows following request

изображение

And only Mastodon server in list изображение Or friends = mutual following? Inside followers list there is no my GtS account

grishka commented 1 month ago

Friends does mean mutual following. So your server must ignore my Accept{Follow} for some reason 🤔

SadmL commented 1 month ago

May be chat with GtS devs about this in this issue? https://github.com/superseriousbusiness/gotosocial/issues/3229

grishka commented 1 month ago

Can you try unfollowing him and following again now?

SadmL commented 1 month ago

If need to reload actor object again, I must wait for 6 hours: https://github.com/superseriousbusiness/gotosocial/issues/3229#issuecomment-2308404994

if you wait 6hrs since you last fetched the account, on next fetch gotosocial will refresh the account. we put it on a cool down to limit unnecessary traffic most of the time. though most of the time accounts on servers will be kept up-to-date by sending each other Update Actor activities.

grishka commented 1 month ago

No you don't need to reload anything, I just changed how I handle incoming Follow activities when the remote actor already follows the local one.

SadmL commented 1 month ago

Nothing changed 🤷

SadmL commented 1 month ago

I don't know, may be it is mutual thing, can you try follow me? @sl@gts.sadium.cyou GtS have no web push notifications yet, so it might take some time before I see it 🙃 And if I see it at all...

grishka commented 1 month ago

Well, I can't even load the actor because of the invalid @context, so I suppose we found the culprit. The only thing I can fix on my side is the UI getting stuck in loading state instead of showing an error. nvm, it does actually show an error

SadmL commented 1 month ago

Well-p, looks like need to wait when https://github.com/superseriousbusiness/gotosocial/issues/1947 and https://github.com/superseriousbusiness/gotosocial/issues/240 get resolved, I guess...

tsmethurst commented 1 month ago

This will be resolved on GtS's side by https://github.com/superseriousbusiness/gotosocial/pull/3243, which will be included in GoToSocial v0.17.0. In a few minutes I'll deploy a version of GoToSocial on https://goblin.technology that includes this fix already, so you can try dereferencing (for example) https://goblin.technology/users/tobi from Smithereen and see if your json-ld parser is happy with it :)

grishka commented 1 month ago

@tsmethurst it works! (I need to fix my CSS to stretch small avatars) edit: done

SadmL commented 1 month ago

After updating my instance to latest atm https://github.com/superseriousbusiness/gotosocial/commit/e10aa76612bf20ca2a5aa8e7ee5e4d1aae0ba69f, can confirm it's working изображение

изображение

tsmethurst commented 1 month ago

Hurray!