grishka / appkit

Android app boilerplate + image loader
50 stars 17 forks source link

Fix for excessive post highlighting when slow-scrolling #14

Closed Xen4n closed 8 months ago

Xen4n commented 8 months ago

Problem

When user is slow-scrolling (keeps finger unmoved during some milliseconds), there are ripple highlight starts (when there is no tap, just scroll). For Moshidon app it looks awful.

Fix

UsableRecyclerView:onShowPress gesture reaction was removed. But when user LongPressed it still highlights.

grishka commented 8 months ago

So you've simply removed the highlighting on a non-long tap? That's not something I want. And "excessive highlighting" isn't even a real problem, that's just how all lists in all apps work. Look at what other apps do — they all highlight the list item you're tapping if you don't start moving your finger immediately after touching the screen.

Xen4n commented 8 months ago

In other apps highlight brightness is significantly lower or without long ripple effect, or for example 'Threads' and 'Tooots' does not have such highlight at all.