search

grishka / libtgvoip

VoIP library for Telegram clients
The Unlicense
389 stars 158 forks source link

Fixed input becoming inaudible after unmuting. #32

Closed shemanaev closed 6 years ago

shemanaev commented 7 years ago

Should fix telegramdesktop/tdesktop#3502. I'm unsure is this a right way to fix this as i'm not very familiar with webrtc_dsp, but this worked for me. Also, tested only on Windows 10 with latest Telegram Desktop.

stek29 commented 7 years ago

Does this just disable AEC? What's the point of having multiple bools with the same purpose?

shemanaev commented 7 years ago

It disables temporarily only appending to farend buffer while mic muted. If you want use enableAEC for this purpose you still need previous state of this variable stored somewhere.

2017-07-20 17:27 GMT+03:00 Viktor Oreshkin notifications@github.com:

Does this just disable AEC? What's the point of having multiple bools with the same purpose?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/grishka/libtgvoip/pull/32#issuecomment-316720840, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAm6eDI0RbvAJtJgXfh3Q3rmAci9x8Sks5sP2PsgaJpZM4OeBZS .

grishka commented 7 years ago

I believe I fixed this myself a while ago by not actually disabling the audio input but by dropping the data when the mic is muted.

shemanaev commented 7 years ago

Sorry for delay, saw that commit, but haven't time to test. It's cracking sound now instead of silence after unmuting with your solution 😞

grishka commented 6 years ago

You were actually right that the problem was with the echo canceller (I hate this thing because it's much like a black box with magic inside but we need it). I've managed to reproduce this myself and fixed it.