search

grishnagkh / vqmetric

video metric cpp implementation
4 stars 6 forks source link

fixed some errors and added option to ignore frame rate #3

Closed farindk closed 5 years ago

farindk commented 5 years ago

Static floating point member variable initialization must be constexpr.

farindk commented 5 years ago

I added an option to ignore the frame-rate of the inputs as I experienced a problem when processing single frames with fake frame rates.

Furthermore, I fixed the parsing of the Y4M header. This trace shows how it was going wrong before: |W1216 H912 F25:1 Ip A0:0 C420jpeg XYSCSS=420JPEG | |H912 F25:1 Ip A0:0 C420jpeg XYSCSS=420JPEG | |F25:1 Ip A0:0 C420jpeg XYSCSS=420JPEG | |Ip A0:0 C420jpeg XYSCSS=420JPEG | |A0:0 C420jpeg XYSCSS=420JPEG | |C420jpeg XYSCSS=420JPEG | |XYSCSS=420JPEG | |CSS=420JPEG |

The parameter starting with 'X' was not correctly skipped and then mistaken for a 'C' parameter.

grishnagkh commented 5 years ago

The changes seem reasonable to me :)