Add file with build revision

grisp / grisp-software

Toolchain and Examples for GRISP

28 stars 5 forks source link

Add file with build revision #23

Closed holzingk closed 6 years ago

c-mauderer commented 7 years ago

I don't really have a problem with merging this but just out of curiosity: What is the purpose of that file?

If for example you want to use it in some c file for printing a revision, it would be a better solution to directly generate a header (maybe in libgrisp).

holzingk commented 7 years ago

I tend to forget which revision I build my toolchain with.

We can also read it with our Erlang build tools, to warn users if something changed in RTEMS so that they rebuild Erlang maybe.

I don't know if keeping track of the build revision is necessary at all, or if it can be obtained otherwise.

Writing it in a C header could be valuable as well, but it's hard to access that value from Erlang during buildtime.

Maybe keep that open and wait for other people's comments?

c-mauderer commented 7 years ago

If it's just a reminder for the toolchain version, the file should be generated in the rtems-install directory.

eproxus commented 6 years ago

+1 to this change. Both a file and header seems useful. I think reading it from a header file shouldn't be a big problem, ever from Erlang

c-mauderer commented 6 years ago

OK. So basically the following changes would be good before merging that patch:

Create the file in rtems-install
(optional because there is currently no use case) generate a header file like rtems-install/rtems/4.12/arm-rtems-4.12/atsamv/lib/include/grisp/build-version.h.

holzingk commented 6 years ago

Okay. Will update PR.

I could also create a .hrl file.

eproxus commented 6 years ago

@nextl00p Create a .hrl file as well, maybe we can find a use for it

holzingk commented 6 years ago

Updated!

c-mauderer commented 6 years ago

Looks mostly OK for me. Two points:

I think the entry in .gitignore is no longer necessary with the new version of the patch.
I'm really not sure whether the headers in ${PREFIX}/include can be used by an application. Try whether you can include it in some of the applications and still compile it. ${PREFIX}/${TARGET}/${BSP_NAME}/lib/include/grisp would be an alternative path for that.