search

grisp / rebar3_grisp

Rebar plug-in for GRiSP
https://www.grisp.org
Apache License 2.0
21 stars 10 forks source link

SEA-232 fix http escaping #80

Closed GwendalLaurent closed 6 months ago

GwendalLaurent commented 6 months ago

In this PR, the templates have been modified to avoid http escaping. For examples, quotes (") are now rendered as " and not &quote; This PR is linked to the PR on grisp_tools: https://github.com/grisp/grisp_tools/pull/23

matlaj commented 6 months ago

If I set the cookie to űáéú, I get an Unexpected error: badarg and the CLI exits. (erl -sname mynode -setcookie űáéú works). Maybe we should always put the cookie between single quotes?

matlaj commented 6 months ago

The Wi-Fi password asd"é9\dfg$ ends up being like this in the wpa_supplicant.conf file: psk="asd"�9\dfg$"

matlaj commented 6 months ago

The CLI flow completes even if a grisp project with the same name already exists in the current folder. I just get green printouts about files already existing. The CLI should only accept the project name if there isn't a folder with the same name in the current folder.

matlaj commented 6 months ago

I also get a badarg exit if the path to the SD card is /tmp/űáú

matlaj commented 6 months ago

And there is a badarg exit for the SSID Űáú, but only at the end of the CLI flow.

matlaj commented 6 months ago

When the CLI starts, it prints ===> Plugin grisp_tools does not export init/1. It will not be used.. Users might think that this indicates a problem. Can we implement a dummy init/1 function or silence this warning in some other way?