gristlabs / asttokens

Annotate Python AST trees with source text and token information
Apache License 2.0
172 stars 34 forks source link

Replace deprecated imp module with importlib #108

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

This library uses the imp module which has been deprecated since Python 3.4 and set for removal in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

dsagal commented 1 year ago

Actually, asttokens does not use the imp module. It is present in one of test fixtures that tests read for testing some parsing logic. Anything in the tests/testdata directory is only parsed by tests but not executed, and it shouldn't make a difference whether an import mentioned in that directory is deprecated or if it's even exists.

hugovk commented 1 year ago

Good to hear, thanks for checking!