search

gristlabs / asttokens

Annotate Python AST trees with source text and token information
Apache License 2.0
172 stars 34 forks source link

Typing support #72

Closed palfrey closed 2 years ago

palfrey commented 2 years ago

Any thoughts on this @dsagal @alexmojaki?

alexmojaki commented 2 years ago

Can you revert the skips you added for Python 2 and see if they pass now?

palfrey commented 2 years ago

Can you revert the skips you added for Python 2 and see if they pass now?

I've just tried that locally, and they're still broken

alexmojaki commented 2 years ago

Please revert the skips and the unicode related changes and push. The tests were working before, and only adding type comments shouldn't change that. If the previous code broke typing, that's a typing problem and that's secondary.

palfrey commented 2 years ago

Please revert the skips and the unicode related changes and push. The tests were working before, and only adding type comments shouldn't change that. If the previous code broke typing, that's a typing problem and that's secondary.

Yup, you're right. I reset bits of the changes, removed the test skips and added a typing workaround for an upstream bug and it's working better now. Still one test to fix, but working on it...

alexmojaki commented 2 years ago

:+1: I'm happy. Thanks for your patience! @dsagal ?

alexmojaki commented 2 years ago

Thanks for all your hard work @palfrey !