search

gristlabs / asttokens

Annotate Python AST trees with source text and token information
Apache License 2.0
172 stars 34 forks source link

Upgrade pypy test list to all the available ones #78

Closed palfrey closed 2 years ago

palfrey commented 2 years ago

The old form is getting removed as of setup-python v3, and it's worth probably testing all of them.

alexmojaki commented 2 years ago

Sounds good to me. @dsagal ?

palfrey commented 2 years ago

@alexmojaki Can this be merged?

alexmojaki commented 2 years ago

@palfrey it looks like the combination of this and #72 don't work. The last build on master failed for every version on the mypy step: https://github.com/gristlabs/asttokens/actions/runs/2141385979

palfrey commented 2 years ago

https://github.com/gristlabs/asttokens/blob/master/.github/workflows/build-and-test.yml#L48 needs editing for the new build names. I'd expected 3.8 to work, but apparently not, so that needs looking at

palfrey commented 2 years ago

Sadly, pypy 3.8's promises of working with mypy were wrong as there's still at least one bug. https://github.com/gristlabs/asttokens/pull/80 filters out all those builds.

TBH, I was expecting you to merge one of the PRs, update the other to master and see failures, not just merge both!