When an URL ends with a dash, it does not behave well at opening the link - Githubissues

gristlabs / grist-core

Grist is the evolution of spreadsheets.

https://www.getgrist.com/

Apache License 2.0

7.04k stars 311 forks source link

When an URL ends with a dash, it does not behave well at opening the link #1200

Open xmontero opened 3 weeks ago

xmontero commented 3 weeks ago

Describe the current behavior

It removes the dash in the URL.

Steps to reproduce

Set a cell that ends with a dash, like for example one from google drive that might end like this:

https://drive.google.com/open?id=12IpftUgNxxxxxxxxxxxxxxxxxxLKwws-

Not all google drive URLs end with a dash, but it can happen.

Click on the icon like this:

See the open URL in the browser.

It gives 404 naturally.

Describe the expected behavior

It should respect the URL that is stored in the cell.

Where have you encountered this bug?

[ ] On docs.getgrist.com
[x] On a self-hosted instance

Instance information (when self-hosting only)

Grist instance:
- Version: I don't know how to see the version from the running instance. I run it about 1 month ago maybe.
- URL (if it's OK for you to share it): It's on localhost
- Installation mode: docker
Browser name, version and platforms on which you could reproduce the bug: Firefox