gristlabs / grist-core

Grist is the evolution of spreadsheets.
https://www.getgrist.com
Apache License 2.0
7.27k stars 322 forks source link

Make it more obvious that breadcrumb items are editable #1250

Closed manuhabitela closed 1 week ago

manuhabitela commented 1 month ago

Describe the problem to be solved

:wave:

Hey, small thing here but I feel it's not really obvious that the document name and page name are editable in the breadcrumbs in the top. I feel like the fact that it's a breadcrumb, we are not used that such UI elements can be edited.

So there is some questioning at first: how do I rename my document?

Then I hover my mouse on the name and I'd admit I feel the UI is also here a bit hard to directly understand we can modify it. The cursor changes to an editable but again, we are not used to being able to edit normal text as it, visually I feel it could be more explicit.

Describe the solution you would like

I feel we could be more explicit that this is the place to edit the document name:

image image

What do you think? :)

lusebille commented 3 weeks ago

Linked to ticket #1171

manuhabitela commented 3 weeks ago

Oh sorry I didn't see the earlier issue. I guess we can close this?

lusebille commented 3 weeks ago

I will keep it because it's related to A11y so one reason more to work on this ticket / to be integrated

dsagal commented 2 weeks ago

@manuhabitela , could you review the design in #1171 for accessibility? That one's marked as "ready to dev", so if looks OK from a11y standpoint, then I propose adding the Accessibility label to #1171 and closing this issue as a duplicate.

manuhabitela commented 1 week ago

You are right, left a small comment on #1171 but yeah, this current issue is not necessary anymore.