gristlabs / grist-core

Grist is the evolution of spreadsheets.
https://www.getgrist.com
Apache License 2.0
7.23k stars 320 forks source link

Document access denied, a string is not translated. #627

Open anaisconce opened 1 year ago

anaisconce commented 1 year ago

The page that is shown when access is denied to a document has an untranslated string, You do not have access to this document. I looked in Weblate and I couldn't find the string. It may be missing?

untranslated string

paulfitz commented 1 year ago

I think so far translation of Grist has been almost entirely of the web client, and not the app server - compare the size of "server" versus "client" files in this directory: https://github.com/gristlabs/grist-core/tree/main/static/locales

Looks like that error message is issued by the app server, and just echoed by the client.

To resolve, the client could detect the kind of error and describe it itself, rather than passing on text from the server, or localization work could extend to the server.

At the start of the localization project, three distinct areas were identified:

I think @berhalak set up machinery for localizing the server back when the translation project led by ANCT started. @vviers do you have thoughts on what to do about localizing error messages and such?

vviers commented 1 year ago

I don't really have a strong opinion on the topic — maybe @CamilleLegeron (who has led our translation efforts) can chip in :)

vviers commented 1 year ago

To resolve, the client could detect the kind of error and describe it itself, rather than passing on text from the server, or localization work could extend to the server.

Would this mean editing code in two different places if/when refactoring errors in the backend ? if so, I think I'd rather translate the server and keep it tidy