Closed fflorent closed 2 months ago
Name | Link |
---|---|
Latest commit | 2e4ff8c0444b42e6604a32493486242e5679fef5 |
Latest deploy log | https://app.netlify.com/sites/grist-help-preview/deploys/668ebb8f1b76d2000836ff99 |
Deploy Preview | https://deploy-preview-360--grist-help-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I expected that it would encourage to help translating the website, if we advertise it as needing some work from the community.
That being said, probably in such a case we should either make it explicit that it's still in beta phase, or continue translating on our side before making it public.
I don't mind waiting until we have more content in French (so opt for the second option), and until then close or make this PR as "WIP".
How about if this message were rewritten a bit for the case where most translations are missing.
Like "We're just getting started translating this language, sorry! We show partially translated languages so translators can track progress. This page isn't translated yet. But you can help..." maybe?
@paulfitz That's interesting. I would need to be sure of the purpose(s) you have in mind for the message so I can enhance relevantly (also I may need to tweak a bit the code depending on your answer):
I like the option of having the "work in progress, help needed" warning message @paulfitz ! Sorry for falling behind on translation we'll get to it this summer !
I propose this message based on your suggestion:
We're just getting started translating this language, sorry!
We show partially translated languages to track progress.
This page isn't translated yet. But the good news is that you can join the translation community to help us 👋{.internal-link target=_blank}.
It's rendered like below in French:
@paulfitz Do you mean like this? (The font size is set like for the other elements on the top)
I pushed an update of the code in a separate commit. Your feedback is welcome
That is a welcome tweak. But what we hand in our mind with this kind of dropdown used in the Grist app:
This PR is good to land in my opinion, and I wouldn't actually want to hold it for a discussion about a fancier dropdown. We could revisit when there's at least one complete translation :-)
Thanks for the clarification!
I merge as suggested, we'll work on that in a follow-up
This allows the user to show the documentation in French for now and in other languages in the future.