gristlabs / grist-help

Grist documentation and help center articles
https://support.getgrist.com
Other
13 stars 17 forks source link

Show language selector! #360

Closed fflorent closed 2 months ago

fflorent commented 2 months ago

This allows the user to show the documentation in French for now and in other languages in the future.

netlify[bot] commented 2 months ago

Deploy Preview for grist-help-preview ready!

Name Link
Latest commit 2e4ff8c0444b42e6604a32493486242e5679fef5
Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/668ebb8f1b76d2000836ff99
Deploy Preview https://deploy-preview-360--grist-help-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fflorent commented 2 months ago

I expected that it would encourage to help translating the website, if we advertise it as needing some work from the community.

That being said, probably in such a case we should either make it explicit that it's still in beta phase, or continue translating on our side before making it public.

I don't mind waiting until we have more content in French (so opt for the second option), and until then close or make this PR as "WIP".

paulfitz commented 2 months ago

How about if this message were rewritten a bit for the case where most translations are missing.

Screenshot from 2024-07-09 13-14-19

Like "We're just getting started translating this language, sorry! We show partially translated languages so translators can track progress. This page isn't translated yet. But you can help..." maybe?

fflorent commented 2 months ago

@paulfitz That's interesting. I would need to be sure of the purpose(s) you have in mind for the message so I can enhance relevantly (also I may need to tweak a bit the code depending on your answer):

vviers commented 2 months ago

I like the option of having the "work in progress, help needed" warning message @paulfitz ! Sorry for falling behind on translation we'll get to it this summer !

fflorent commented 2 months ago

I propose this message based on your suggestion:

We're just getting started translating this language, sorry!

We show partially translated languages to track progress.

This page isn't translated yet. But the good news is that you can join the translation community to help us 👋{.internal-link target=_blank}.

It's rendered like below in French:

image

fflorent commented 2 months ago

@paulfitz Do you mean like this? (The font size is set like for the other elements on the top) image

fflorent commented 2 months ago

I pushed an update of the code in a separate commit. Your feedback is welcome

paulfitz commented 2 months ago

That is a welcome tweak. But what we hand in our mind with this kind of dropdown used in the Grist app:

language-dropdown

This PR is good to land in my opinion, and I wouldn't actually want to hold it for a discussion about a fancier dropdown. We could revisit when there's at least one complete translation :-)

fflorent commented 2 months ago

Thanks for the clarification!

I merge as suggested, we'll work on that in a follow-up