gristlabs / grist-help

Grist documentation and help center articles
https://support.getgrist.com
Other
13 stars 17 forks source link

From weblate to gitlocalize #384

Closed fflorent closed 2 weeks ago

fflorent commented 1 month ago

This PR:

Fixes #370

netlify[bot] commented 1 month ago

Deploy Preview for grist-help-preview ready!

Name Link
Latest commit 6b537b8b716a306b742719c8f67fd40df626f595
Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66c88993943d8500082a20e2
Deploy Preview https://deploy-preview-384--grist-help-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fflorent commented 3 weeks ago

@dsagal

The biggest one is: it doesn't seem to be possible to mark a translated article as good enough to not require warnings, i.e. it would always show either then "not yet translated" warning or "needs improvement" warning. Do you have a plan for that?

I propose to declare a property to tell which documents have been reviewed by a human and can be considered of enough quality to remove the warning. I'll work on that next week if you agree on that proposal.

Also, I noticed that the French homepage shows both warnings. This doesn't seem right.

I removed the warning in dc98650df49907277bc43ae633e64fe8f439d549, which is a commit of my other PR #388

Also, could you please rebase your branch on the latest master? There was a recent fix to an issue with the formatting of functions.md (e.g. seen here), and it would be good to make sure it's not affected by your changes.

Done!

fflorent commented 2 weeks ago

Thank you @dsagal!