gristlabs / grist-help

Grist documentation and help center articles
https://support.getgrist.com
Other
13 stars 17 forks source link

Fixes function searching and jumping #389

Closed Spoffy closed 3 weeks ago

Spoffy commented 3 weeks ago

This PR:

netlify[bot] commented 3 weeks ago

Deploy Preview for grist-help-preview ready!

Name Link
Latest commit 61f04e22de19d1477484e8cf29deae9c134d6bc6
Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66c603cc3567160007fe39ec
Deploy Preview https://deploy-preview-389--grist-help-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dsagal commented 3 weeks ago

Thank you @Spoffy ! There is another piece of behavior that seems to need fixing: when clicking on a link to go to a function, we used to have a bit of JS that expands that function (since normally all are collapsed). It is in expandSelected() in help/en/docs/js/grist.js.

Spoffy commented 3 weeks ago

Thank you @Spoffy ! There is another piece of behavior that seems to need fixing: when clicking on a link to go to a function, we used to have a bit of JS that expands that function (since normally all are collapsed). It is in expandSelected() in help/en/docs/js/grist.js.

Thanks for pointing me at the right file - this should be all sorted now too!