gristlabs / grist-help

Grist documentation and help center articles
https://support.getgrist.com
Other
13 stars 17 forks source link

oidc: clarify a small point of quoting an envvar #391

Closed jordigh closed 2 weeks ago

jordigh commented 3 weeks ago

Ran into this problem by quoting in my .env file for Docker:

https://community.auth0.com/t/id-token-not-present-in-tokenset/63690/2

netlify[bot] commented 3 weeks ago

Deploy Preview for grist-help-preview ready!

Name Link
Latest commit 4ff92952df6574205a88a0629f582721bb6e0b21
Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66c8b47586c5570008e40953
Deploy Preview https://deploy-preview-391--grist-help-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jordigh commented 3 weeks ago

@dsagal Well, now I wonder why is it a config option at all. Grist already knows the scopes it needs, so why even make it configurable?

dsagal commented 3 weeks ago

Good question, I don't know, only have a vague guess. @fflorent , do you know the answer to @jordigh's question?

fflorent commented 3 weeks ago

Indeed, good question @jordigh!

Here are some explanations I have in mind:

These explanations may not be highly convincing (especially my second point). We may have introduced this env variable when needed or requested by the community.

jordigh commented 2 weeks ago

@fflorent Okay, I thought Grist just wouldn't work if it didn't have all of the scopes, but if degraded performance is possible with fewer scopes than the default, that's good to know.

@dsagal Even if it's the default value, I think it's helpful to highlight in the examples that this value exists.

Given that, I'm merging this in.