gristlabs / grist-help

Grist documentation and help center articles
https://support.getgrist.com
Other
13 stars 17 forks source link

Move admonition to the top of the page #398

Closed fflorent closed 1 week ago

fflorent commented 2 weeks ago

Context

The admonition is thought to be displayed after the title of the page.

However, there are some glitch, where the admonition is displayed before the titles, like on the page about the column types, and sometimes even they do not appear at all, like the functions reference (don't take a look at the rendering, this is another PR I will submit ASAP).

Proposed solution

I would say it is fine to display the admonition at the top, before the title. It simplifies the code.

netlify[bot] commented 2 weeks ago

Deploy Preview for grist-help-preview ready!

Name Link
Latest commit a29978cb578dcba9c4bdb2bc6c1552cda4348e01
Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66d08a6d95ad960008e4f086
Deploy Preview https://deploy-preview-398--grist-help-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.