gristlabs / grist-widget

A repository of custom widgets to embed in Grist documents
https://gristlabs.github.io/grist-widget/
Apache License 2.0
55 stars 58 forks source link

swiping through images in viewer widget #117

Closed JakubSerafin closed 7 months ago

JakubSerafin commented 9 months ago

Viewer widget will show buttons prev and next on top, when more that one url can be found in the cell. Also, images can be swiped on mobile via gesture.

netlify[bot] commented 9 months ago

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
Latest commit 9d8a67278c0a88f2b4d53bd67ba496c3bf359fd2
Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/65d377e2f83de10008a7e120
Deploy Preview https://deploy-preview-117--boisterous-sunburst-a5c941.netlify.app/viewer
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JakubSerafin commented 7 months ago

It is good starting point, things that should be improved (in my opinion)

* Overall UI, currently it is not pretty, we can easly use any out of box MIT library https://linxtion.com/demo/react-image-gallery/

* The size of the window is wrong, I see scrollbars all the time.

Overall UI improved to be more similar to that in linxtion. Cannot spot any scrollbar in chrome/firefox unix chrome, but added overlay handling anyway

berhalak commented 7 months ago

When you switch rows from a row that has multiple images to a row with no images at all, those arrows are still there.