search

gristlabs / grist-widget

A repository of custom widgets to embed in Grist documents
https://gristlabs.github.io/grist-widget/
Apache License 2.0
56 stars 60 forks source link

Make map source configurable #126

Closed jperon closed 6 months ago

jperon commented 7 months ago

To make it easier to change map source. For example, (and to test), those values work:

https://tile.openstreetmap.org/{z}/{x}/{y}.png
&copy; <a href="https://openstreetmap.org/copyright">OpenStreetMap contributors</a>
netlify[bot] commented 7 months ago

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
Latest commit 297f1943489667ea63c555a85d83a06b9bb226f1
Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/65f3842f04b2640008f70a20
Deploy Preview https://deploy-preview-126--boisterous-sunburst-a5c941.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hosios commented 7 months ago

I just tried it and it worked perfectly. I would suggest and vote for the merge.

kamazeuci commented 6 months ago

this would be wonderful

kamazeuci commented 6 months ago

it's working beautifully! thanks!!

kamazeuci commented 6 months ago

oops! nope... I mean, it is working, but if you close the map (for example by choosing a new table), then open the map back again, it goes back to ESRI map. In other words, the Map configuration is not saved.

jperon commented 6 months ago

oops! nope... In other words, the Map configuration is not saved.

Did you click the green « Save » after editing the option ?

kamazeuci commented 6 months ago

Oh I see... no, that button is not rendered for me... but when I hover the cursor over the top left corner of the dialogue, it shows a hand so I suppose that is the save button. thanks!!