search

gristlabs / grist-widget

A repository of custom widgets to embed in Grist documents
https://gristlabs.github.io/grist-widget/
Apache License 2.0
57 stars 61 forks source link

Fix tests broken due to widget gallery changes #144

Closed Spoffy closed 1 week ago

netlify[bot] commented 1 month ago

Deploy Preview for boisterous-sunburst-a5c941 ready!

Name Link
Latest commit d7af5bfe106e14c971455dbe404f2583a8b82df2
Latest deploy log https://app.netlify.com/sites/boisterous-sunburst-a5c941/deploys/67335f0bd4701d0008d3bf00
Deploy Preview https://deploy-preview-144--boisterous-sunburst-a5c941.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

paulfitz commented 1 month ago

Took a quick look at this PR. A few notes.

test/gristWebDriverUtils.ts has become weird. It is supposed to be a copy of an asset in grist-core:

/**
 * Utilities that simplify writing browser tests against Grist, which
 * have only mocha-webdriver as a code dependency. Separated out to
 * make easier to borrow for grist-widget repo.
 *
 * If you are seeing this code outside the grist-core repo, please don't
 * edit it, it is just a copy and local changes will prevent updating it
 * easily.
 */

It looks pretty out of date with grist-core today, so I thought about copying over the latest version. BUT it looks like there have been local changes to the file. For example the focusOnCell method. These should either be added upstream, or in GristUtils in test/getGrist.ts.

Copying a file across is of course lame.