search

gristlabs / mkdocs-windmill

Outstanding mkdocs theme with a focus on navigation and usability
Other
106 stars 62 forks source link

Links broken in mkdocs 1.0 #30

Closed murrant closed 5 years ago

murrant commented 6 years ago

See https://mkdocs.readthedocs.io/en/stable/about/release-notes/#template-variables-and-base_url

palto42 commented 6 years ago

Just tried to fix it manually for the Previous/Next navigation at the bottom on the page and it worked. I just added |url template filter to all occurences of *.url in /mkdocs_windmill/article-nav.html.

For example I changed href="{{ page.next_page.url }}" to href="{{ page.next_page.url|url }}"

I have not checked if other files also require this update.

dsagal commented 6 years ago

I think that's far from the only problem with mkdocs 1.0. It seems this particular change should be safe for older mkdocs too, so if you'd like to make a PR for this (and test that it doesn't break mkdocs 0.17, please), I'd be glad to include it.

dsagal commented 5 years ago

This is fixed in mkdocs-windmill v0.1.8.