search

gristlabs / mkdocs-windmill

Outstanding mkdocs theme with a focus on navigation and usability
Other
106 stars 62 forks source link

Remove the #_top anchor for the first element #41

Closed albandewilde closed 4 months ago

albandewilde commented 4 years ago

may the first element in the list isn't at the top of the page, so I change that to match to the element anchor

dsagal commented 4 years ago

The change is sensible, but the behavior with #_top is intentional -- there is no other link that scrolls back to the top, and the first heading is often a suitable choice for it. It's not a perfect behavior, but changing it would be a regression for some cases.

Perhaps this choice could be made somehow a property of the first link?

You can also override the theme just for your site using custom_dir (see https://www.mkdocs.org/user-guide/configuration/#theme).

albandewilde commented 4 years ago

I understand, but isn't that a duplicated feature (scrolling back to top) ? Because on keyboards there already is a key to do that, it's the home key.

Otherwise, it may can be an option which can be configured in the mkdocs.yml file ?

dsagal commented 4 years ago

Yeah, an option would be good.

albandewilde commented 4 months ago

I'm closing this PR because it was opened long time ago and it may be obsolete now.