search

gristlabs / ts-interface-checker

Runtime library to validate data against TypeScript interfaces.
Apache License 2.0
323 stars 18 forks source link

implementation of partial<T> #74

Open mkrouwel opened 5 months ago

dsagal commented 4 months ago

Thank you, but could you please remove the whitespace-only differences and leave only the functionality changes?

mkrouwel commented 4 months ago

Hi, I am struggling with this. I downloaded a clean copy of your repo, created a new fork with only the change on line 145 of index.ts. It took me quite some time to find the VS code setting not to change the formatting. Also I cannot compile or run, because the package.json seems outdated. Nevertheless, when committing I need to pull my previous commits, after which white space is changed again. Please help

Van: Dmitry @.> Verzonden: woensdag 1 mei 2024 15:29 Aan: gristlabs/ts-interface-checker @.> CC: Marien Krouwel @.>; Author @.> Onderwerp: Re: [gristlabs/ts-interface-checker] implementation of partial (PR #74)

Thank you, but could you please remove the whitespace-only differences and leave only the functionality changes?

— Reply to this email directly, view it on GitHubhttps://github.com/gristlabs/ts-interface-checker/pull/74#issuecomment-2088465827, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEILZQMA3TS2QNNAFQSJSGTZADU3RAVCNFSM6AAAAABGQQA4POVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGQ3DKOBSG4. You are receiving this because you authored the thread.Message ID: @.***>

dsagal commented 4 months ago

Hmm, regarding being unable to compile and run, I am not sure why -- it works for me on a clean checkout. I run npm install, then npm run test. Could it be something with node version? I was just trying this on node 18.

As for dealing with whitespace, if you make a new fork with just the relevant changes, you don't need to pull in your previous commits. You can just make a new PR and close this old one. You should also add a test case for the new functionality.

mkrouwel commented 4 months ago

I have node v20. To be honest, fixing al this high code stuff, having the right versions and indentation etc, and writing tests takes me too much time. If you like my work, just merge the relevant lines into your code, or ignore it.

Van: Dmitry @.> Verzonden: vrijdag 3 mei 2024 07:51 Aan: gristlabs/ts-interface-checker @.> CC: Marien Krouwel @.>; Author @.> Onderwerp: Re: [gristlabs/ts-interface-checker] implementation of partial (PR #74)

Hmm, regarding being unable to compile and run, I am not sure why -- it works for me on a clean checkout. I run npm install, then npm run test. Could it be something with node version? I was just trying this on node 18.

As for dealing with whitespace, if you make a new fork with just the relevant changes, you don't need to pull in your previous commits. You can just make a new PR and close this old one. You should also add a test case for the new functionality.

— Reply to this email directly, view it on GitHubhttps://github.com/gristlabs/ts-interface-checker/pull/74#issuecomment-2092350258, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEILZQJ5LKEVZNHR5MSKURDZAMQVTAVCNFSM6AAAAABGQQA4POVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGM2TAMRVHA. You are receiving this because you authored the thread.Message ID: @.***>