grisu / gricli

Grisu commandline client
7 stars 2 forks source link

Potential for a global directory creation boolean #138

Closed sina-masoud-ansari closed 12 years ago

sina-masoud-ansari commented 13 years ago

In response to user question: can jobs files be downloaded into a single dir.

vladimir-mencl-eresearch commented 13 years ago

Maybe also an optional argument to download (and downloadclean) to specify the target local directory?

makkus commented 12 years ago

Yeah, I think I'd prefer having it as an argument to download. Would that be acceptable Sina?

sina-masoud-ansari commented 12 years ago

That would be awesome, I'll test with the user when ready.

makkus commented 12 years ago

Ok, implemented so that last argument can be local directory (but that's optional, if it is not specified, current dir is used like before).

If the specified directory does not exist, it will be created. Also, before one or more jobs are downloaded, it is checked whether a job directory with the same name as one of the to-be-downloaded jobs exists already. If that is the case, an error is thrown.

makkus commented 12 years ago

This also needs documentation.

sina-masoud-ansari commented 12 years ago

Yup, I've been assigned

sina-masoud-ansari commented 12 years ago

Seems to be working well : ) I think it would be good if it had an asynchronous option. Will test with user who raised the issue now.

sina-masoud-ansari commented 12 years ago

Haven't heard back yet, I think this command meets the criteria well, asynchronous option would be good if you guys agree, otherwise please close.

makkus commented 12 years ago

Should be working now...