search

grisu / gricli

Grisu commandline client
7 stars 2 forks source link

set wallclock should notify user when it's outside queue parameters #142

Closed Aethylred closed 12 years ago

Aethylred commented 13 years ago

If the submission queue is know, and GriCli can retrieve the walltime parameters (minimum and maximum walltimes) before job jubmission, GriCli should notifiy the user when set wallclock is outside the queue's parameters.

Examples:

set host ng2.somecluster.ac.nz
set queue a.queue
set walltime 1d
WARNING: 1d walltime is shorter than the minimum walltime limit of 3d for a.queue on ng2.somecluster.ac.nz
set walltime 20d
WARNING: 20d walltime is longer than the maximum walltime limit of 10d for a.queue on ng2.somecluster.ac.nz

This would indicate a similar warning should be given when queue is set and walltime is already set for a job.

yuriyh commented 13 years ago

related to https://github.com/grisu/grisu/issues/23

vladimir-mencl-eresearch commented 13 years ago

+1

makkus commented 13 years ago

It's going to be hard to implement that for this milestone, since there is no direct method in the Grisu API to query those queue parameters. I guess we could maybe hack such a method together, but the whole information-related calls in the API need an overhaul anyway and I'd prefer to do that first. Quite a big thing, though.

There might be a clumsy way to do it with the existing API and I'm happy to try to implement that. One thing we should be aware of, though: this will introduce a delay (no idea how long, probably around a second or 2) every time after the user sets the walltime (or queue). Also, should this checking of whether the selected queue makes sense only happen with the walltime? Might be that other properties of the job don't match the queue.

I agree that it would be nice if we had stuff like that, but is it important enough (at the moment) to implement it? My feeling is that it is expensive to implement for what we get in return...

makkus commented 12 years ago

Unless somebody complains I'll remove the milestone from this. I appreciate that it would be useful but I don't think it is as urgent as the stability issues we are working on at the moment. And since nobody commented here for a while I'll move it out of the near-future milestones...

vladimir-mencl-eresearch commented 12 years ago

Hi Markus, I stayed out of watching Gricli issues for a while. I'm back here and I'm re-stating that Grisu should be checking the wall clock limit submitted against the one advertised by the queue.

Otherwise, we are asking for bad failures where the job fails after running for a couple of days or longer - would be frustrating for the user and would create the impression "this thing is broken, why to use the grid". Cheers, Vlad

makkus commented 12 years ago

On hold until mds-replacement is decided. Don't want to spend time on this right now when it's likely that it would be way easier after an info-system re-design (which is getting more and more urgent)...

Will leave open...