grisu / gricli

Grisu commandline client
7 stars 2 forks source link

exec special chars #146

Closed sina-masoud-ansari closed 12 years ago

sina-masoud-ansari commented 13 years ago

exec ls g* ie exec with glob doesn't work on dev, can somebody please confirm? cheers

vladimir-mencl-eresearch commented 13 years ago

You might run into some interesting issues with defining correct behavior - i.e., what kind of expansion should happen on arguments to an exec.

If you just exec - in the sense of exec(3) - no globbing happens and you just invoke ls with "g*", so it would be listing files that are named gee-star (a literal star).

If you typed ls g* in bash, bash would do the globbing and pass the expanded list to ls.

Do we want gricli to do globbing on local files? Do we do exec through bash - as in bash -c "ls g*"

I don't know the answer, I'm just reporting on what I see in the can of worms that got just open :-)

yuriyh commented 13 years ago

it is not as bad as submit command can of worms... how about new variable, shell, default value = bash on linux? or maybe default = user shell in passwd if we can get that reliably...

makkus commented 12 years ago

How important is that?

sina-masoud-ansari commented 12 years ago

Well, it is nice to be able to not switch to another shell window to do more complex commands but I think we should we should wait for more user demand because

a) we save development and testing time and the cost to the user is not that great b) we need to know how many users are actually using the client interactively before spending more time on interactive features

More advanced users who will be using the client in this way are more likely to be scripting / piping commands Novice users may also use scripts and simply change parameters without spending much time in the client which also has implications for the visibility of our commands and help documentation.

makkus commented 12 years ago

Closing this for now. Please re-open if necessary.