search

grisu / gricli

Grisu commandline client
7 stars 2 forks source link

Some more unset issues #160

Closed sina-masoud-ansari closed 12 years ago

sina-masoud-ansari commented 13 years ago

Just went through the rest ...

Not sure if you want to do this for this milestone but perhaps instead of null, they can be the default values? Instead of 'cannot be set to null' we could say 'cannot be unset' followed by the reason.

gricli> unset cpus variable cpus cannot be set to null reason: variable cannot be unset

must be at least 1 ?

gricli> unset debug variable debug cannot be set to null reason: must be either true or false

set to default : false ?

gricli> unset description variable description cannot be set to null reason: variable cannot be unset

should be '' ?

gricli> unset dir command failed. Either connection to server failed, or this is gricli bug. Please send /Users/local/EC/smas036/.grisu.beta/gricli.debug to eresearch-admin@auckland.ac.nz together with description of what triggered the problem

should be home dir or 'must be set' ?

gricli> unset email variable email cannot be set to null reason: variable cannot be unset

should be '' ?

gricli> unset email_on_finish variable email_on_finish cannot be set to null reason: must be either true or false

go to default case

gricli> unset gdir variable gdir cannot be set to null reason: variable cannot be unset

set to df home?

gricli> unset group variable group cannot be set to null reason: variable cannot be unset

group must be set

gricli> unset jobname command failed. Either connection to server failed, or this is gricli bug. Please send /Users/local/EC/smas036/.grisu.beta/gricli.debug to eresearch-admin@auckland.ac.nz together with description of what triggered the problem

go to default case or ''

gricli> unset prompt variable prompt cannot be set to null reason: variable cannot be unset >> default or '>'

gricli> unset walltime command failed. Either connection to server failed, or this is gricli bug. Please send /Users/local/EC/smas036/.grisu.beta/gricli.debug to eresearch-admin@auckland.ac.nz together with description of what triggered the problem

must be set or default case?

yuriyh commented 13 years ago

i will fix the cases when it says "command failed" for this release. will have a look at the rest for next.

makkus commented 12 years ago

Seems good to me now. Closing.