grisu / gricli

Grisu commandline client
7 stars 2 forks source link

set memory in decimal format #223

Closed sina-masoud-ansari closed 12 years ago

sina-masoud-ansari commented 12 years ago

(_1) jobs> set memory 1.2g variable memory cannot be set to 1.2g reason: not a valid memory format (_1) jobs> set memory 1g200m (*1) jobs> print global memory memory = 1.20 GB

For larger memory sizes a decimal value may be more convenient

makkus commented 12 years ago

Hm. Is that a good idea, given that those numbers are not really in the decimal system, but binary. I.e. a gigabyte is 1024x1024x1024 kb (or some such), not 1000x1000x1000.

Wouldn't that be more confusing than convenient?

sina-masoud-ansari commented 12 years ago

I think you're right where users are debugging. The difference in this case is about 7%. I'll close and we can reopen if needed.