grith / sibboleth

Non-web shibboleth client
5 stars 3 forks source link

Minor fix: Remove local idps attribute from Idp python class #4

Closed vladimir-mencl-eresearch closed 12 years ago

vladimir-mencl-eresearch commented 12 years ago

The Idp python class in sibboleth/credentials.py was defining its own set_idps method that was assigning to the idps attribute - which was clashing with how jython maps the set_idps method inherited from grixth.sibboleth.IdpObject.

Any attempts to instantiate the Idp python class were failing with

import sibboleth.shibboleth idp = sibboleth.Idp("UoC") Traceback (most recent call last): File "", line 1, in File "pyclasspath/sibboleth/credentials.py", line 125, in init File "pyclasspath/sibboleth/credentials.py", line 131, in set_idps AttributeError: read-only attr: idps

It was still possible to instantiate grith.sibboleth.StaticIdpObject.

This commit removes the (otherwise unused) local attributes and accessor methods from the python Idp class, deferring the handling to the methods inherited from grixth.sibboleth.IdpObject.