Closed vmakhaev closed 6 years ago
Wouldn't it make sense to have it in a separate package?
Yes, I think at least storages and types can be places to separate packages as soon project become a little bit mature.
And also swarm-storage
package can include Storage base class and universal test suite for all storages.
Maybe we can do the same for data types.
Indeed, as level-storage adds a non trivial dependency, it should ideally go into a separate package... Also, adding the level stuff into the default client bundle is a no-go. I'll cherry pick from this PR. On 19 Oct 2014 14:33, "Vladimir Makhaev" notifications@github.com wrote:
And also swarm-storage package can include Storage base class and universal test suite for all storages. Maybe we can do the same for data types.
— Reply to this email directly or view it on GitHub https://github.com/gritzko/swarm/pull/28#issuecomment-59645686.
see c0ace7af486a2c513ba1a9c8aab6613263d4d70b comments are welcome
Merged. By the way, guys, do you know how to preserve history on merge? It says LevelStorage is a new file. https://github.com/gritzko/swarm/commit/9131847d4399ea0b150781df029885b4a021ef00
level-packager
andleveldown
/level-js
for isomorphic storage