Experiment adding flowtype

andreypopp commented 8 years ago

Adds type annotation to LamportTimestamp and Spec. Discuss!

andreypopp commented 8 years ago

It builds on top of es6 branch as it requires babel toolchain and class syntax makes things easier.

andreypopp commented 8 years ago

Other observations:

There are a lot of "seemingly" unused code in the repo. "Seemingly" is just because I can't be sure it's won't be used in the near future. Examples are VV and {add,remove}Reaction APIs.
API is highly polymorphic, a lot of functions takes a wide variety of argument types and its combination. That's not only harder to type (flow type is quite good with unions) but also makes code less readable and clear (at least for me). I suggest splitting constructors into several factory functions in such places (Spec, Op for example).

gritzko commented 8 years ago

I am getting rid of polymorphic APIs gradually, so we agree on that.

VV is nicer than VVector, but it makes no immediate difference, so it got stuck in this state. Reactions can be used by app developers. Swarm.js itself does not use them.

gritzko / swarm

Experiment adding flowtype #77