search

grizzthedj / foreman_ipam

Foreman plugin for integration with External IPAM providers
GNU General Public License v3.0
11 stars 8 forks source link

Description for plugin role #16

Open stejskalleos opened 4 years ago

stejskalleos commented 4 years ago

Hi, in the Foreman we are trying to add descriptions to all roles added from plugins, I would like to ask you kindly if you can add some description to your plugin's role ExternalIpam?

Change is very easy, you can add description as third argument to role function in engine.rb file.

Thank you very much

grizzthedj commented 4 years ago

The description has been added and pushed to v0.0.13

grizzthedj commented 4 years ago

@stejskalleos It seems that adding the description broke the foreman start process. I have removed this from a newly pushed version(v0.0.14) temporarily until I sort this out, at which time I will push a new fix.

stejskalleos commented 4 years ago

Hi, maybe it's caused by old version of foreman, description for roles have been added in 1.20 version.

grizzthedj commented 4 years ago

This was tested on v1.25.0