search

grml / grml-debootstrap

wrapper around debootstrap
59 stars 27 forks source link

code simplification #230

Closed adrelanos closed 10 months ago

adrelanos commented 11 months ago

Remove unnecessary use of eend 0.

fixes https://github.com/grml/grml-debootstrap/issues/229

mika commented 10 months ago

Ah, nice catch, thanks! That seems to be a leftover from c87dc4ae.

nitpick: please slightly improve the commit message, the code simplification in the first line would show up as such in debian/changelog and doesn't tell much :)

So I'd propose something like:

code simplification: drop NOP usage of eend 0

Remove unnecessary use of `eend 0`, which does effectively nothing.
Leftover from git rev c87dc4ae where we moved from grml-etc-core's
lsb-functions functions to a simplified version of them.

Closes: https://github.com/grml/grml-debootstrap/issues/229

(Let me know if you'd prefer me to take care of it)

adrelanos commented 10 months ago

Commit message updated.

I couldn't have invented that commit message myself. :)

mika commented 10 months ago

Commit message updated.

Great, thanks! Merged!

I couldn't have invented that commit message myself. :)

:)