improve error handling 2

adrelanos commented 9 months ago

https://github.com/grml/grml-debootstrap/pull/231

adrelanos commented 9 months ago

modprobe loop

modprobe: FATAL: Module loop not found in directory /lib/modules/6.2.0-1015-azure

Seems like an upstream issue as per https://github.com/microsoft/WSL/issues/10450

Previously without strict error handling, the CI simply didn't notice this issue. Solutions:

A) One easy solution would be to ignore it using "|| true". This requires the least code. I'll do this for now to progress with testing on CI. Can be refined after I received feedback. Should I do this and add a comment with a link to that github issue?
B) Maybe modprobe loop is no longer necessary and could be removed?
C) Ignore this conditionally on CI only. Would require an "if", some environment variable or command line option such as --ci.

adrelanos commented 9 months ago

A) One easy solution would be to ignore it using "|| true". This requires the least code. I'll do this for now to progress with testing on CI.

Done.

New issue. The following command has a non-zero exit code:

blkid -o value -s TYPE /dev/disk/by-uuid/4f263a0c-b7b6-4998-b066-247fb3310d97

Any idea why that might be?

adrelanos commented 9 months ago

This blkid related bug probably:

existed earlier already,
hasn't been spotted before,
the new strict error handling in this PR simply made this bug visible,
but this PR isn't the cause of this issue,
maybe only happening on CI (which previously did not exist).

Can I ignore it for the purpose of this PR and create a follow-up issue instead? This is what I'll do for now so I can progress with further testing.

adrelanos commented 9 months ago

blkid issue...

Can I ignore it for the purpose of this PR and create a follow-up issue instead? This is what I'll do for now so I can progress with further testing.

Done.

Now, the CI is mostly passing except for the builds of Debian stretch are failing.

+ apt-get update
...
Err:5 http://security.debian.org/ stretch/updates/main amd64 Packages
  404  Not Found
...
W: The repository 'http://security.debian.org/ stretch/updates Release' does not have a Release file.
E: Failed to fetch http://security.debian.org/dists/stretch/updates/main/binary-amd64/Packages  404  Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead.

Not sure if this is an intermittent issue because Debian jessie does not have this issue?

Potential solutions:

A) Dropping support for Debian stretch. This requires the least code. I am not a big fan of supporting legacy versions but you might have other requirements here.

Quote https://wiki.debian.org/DebianStretch

Security updates have been discontinued as of 2020-07-06.

B) Not enabling the security repository for Debian stretch builds.
C) Adding || true for invocations of $APTUPDATE (and similar) but only for Debian stretch builds

grml / grml-debootstrap

improve error handling 2 #248