search

grml / grml-debootstrap

wrapper around debootstrap
59 stars 27 forks source link

improve error handling 3 #255

Closed adrelanos closed 8 months ago

adrelanos commented 9 months ago

Fixes https://github.com/grml/grml-debootstrap/issues/224

adrelanos commented 9 months ago

Debian stretch build still failing as mentioned earlier in https://github.com/grml/grml-debootstrap/pull/248#issuecomment-1817766019.

But not an issue introduced by this PR. This PR here makes the issue only visible.

I compared with an arbitrary different recent PR. A PR not authored by me. Namely this PR:

Here is the relevant excerpt from the other PR build log:

2023-11-18T11:48:47.2487870Z Err:7 http://security.debian.org stretch/updates/main amd64 Packages
2023-11-18T11:48:47.2488469Z   404  Not Found
2023-11-18T11:48:47.2529303Z Get:9 http://archive.debian.org/debian stretch/main Translation-en [5377 kB]
2023-11-18T11:48:47.2586326Z Ign:8 http://security.debian.org stretch/updates/main Translation-en
2023-11-18T11:48:48.6862318Z Fetched 5380 kB in 1s (2900 kB/s)
2023-11-18T11:48:49.1516508Z Reading package lists...
2023-11-18T11:48:49.1748396Z W: The repository 'http://security.debian.org stretch/updates Release' does not have a Release file.
2023-11-18T11:48:49.1750626Z E: Failed to fetch http://security.debian.org/dists/stretch/updates/main/binary-amd64/Packages  404  Not Found
2023-11-18T11:48:49.1752139Z E: Some index files failed to download. They have been ignored, or old ones used instead.

This issue seems parmement. And also not worth reporting to Debian as stretch doesn't have security support by Debian anymore anyhow.

Potential solutions:

Quote https://wiki.debian.org/DebianStretch

Security updates have been discontinued as of 2020-07-06.

I'll attempt to implement option B) for now until I receive other feedback.

adrelanos commented 9 months ago

All tests are passing now except shellcheck but these seem to be unrelated to this PR.

I would appreciate some feedback on how to proceed with this PR.

mika commented 9 months ago

All tests are passing now except shellcheck but these seem to be unrelated to this PR.

Ok great

I would appreciate some feedback on how to proceed with this PR.

Yeah I think we can go forward with this, I left comments on some of the commits, and think we should get rid of the debugging related changes that shouldn't be part of the main grml-debootstrap? (No objections to enable debugging code when running with --debug option or alike though!)

adrelanos commented 9 months ago

I've hopefully addressed all your feedback. Please kindly let me know if there's other blockers to get this merged.

There's a new related issue which is triggered (but not caused) by this PR for which I created a separate issue:

mika commented 8 months ago

Sorry for the delay, finally found some spare minutes to take care of this. Thanks for all your work around this, @adrelanos ! :+1: