search

grml / grml-terminalserver

terminalserver for Grml
4 stars 1 forks source link

can annihilate a box #3

Open yarikoptic opened 10 years ago

yarikoptic commented 10 years ago

well -- not my days really... needed to regrub a box without cdrom/usb boot -- decided to give grml-terminalserver a try blindingly just running it as root from the beginning... it spit out bunch of errors before it exited, and then somehow I have managed to close that screen shell so I lost any track of what it told me .,.. and now I ended up with /bin and /etc being removed, and also no devices under /dev... who knows what else... I haven't done analysis of the script(s) yet but just wanted to complain.

I guess having smth like 'set -eu' at the beginning of the script could save some other souls and exit early instead of I guess proceeding execution with some variables left undefined ;)

mika commented 10 years ago

Uh, I'm sorry to hear that, but I've absolutely no idea what was going on your system. :( I've never ever experienced such an issue (even though grml-terminalserver is running in all kinds of environments). Could you please explain in more detail what you actually did? Did you run it on the Grml live system itself?

yarikoptic commented 10 years ago

It was wheezy Debian installation iirc. I just cloned repo to /tmp, cd to that directory and ran bash grml-terminalserver... this was done in a screen session, with su or sudo to get to root. I guess I would not be able to replicate this fun now. My recommendation still stands on making scripts fail early

On October 2, 2014 4:33:30 PM EDT, Michael Prokop notifications@github.com wrote:

Uh, I'm sorry to hear that, but I've absolutely no idea what was going on your system. :( I've never ever experienced such an issue (even though grml-terminalserver is running in all kinds of environments). Could you please explain in more detail what you actually did? Did you run it on the Grml live system itself?

Reply to this email directly or view it on GitHub: https://github.com/grml/grml-terminalserver/issues/3#issuecomment-57700526

mika commented 10 years ago

Uh alright, I'll try to reproduce that. Sure, the script is supposed to fail early, if it's not doing so that's clearly a bug. Thanks for the followup!