search

grml / live-boot-grml

GNU General Public License v3.0
10 stars 12 forks source link

fixed legacy persistence handling (filesystemlabel live-rw) #1

Closed lukas227 closed 12 years ago

lukas227 commented 12 years ago
evgeni commented 12 years ago

Thanks! I've tried this and it works, sort of :/ It creates a directory called "." (with the quotation marks) on the persistence medium and uses this as a base. So while this enables the use of a old-fashioned persistence setup, one does not get his old environment back :(

evgeni commented 12 years ago

Thinking about it, would something like this work? "${dir} ${opt},source=${backing}" > "${include_list}"

lukas227 commented 12 years ago

Thanks for your feedback. Your suggestion (using source=${backing}) will not work, as a relative path is required, but I think I could fix the problem.

I was misinterpreting the error message I got, which was the following: Skipping unsafe custom mount with option source=.: must bei either "." (the media root) or a relative path w.r.t. the media root that contains neither commas, nor the special "." and ".." path components

It did not want me to quote the dot (".") which is what I did, the dot was just right. Another bug in the initramfs erroneously prevents using the dot. I just added a commit that fixes that one and reverts the quoting of the ".". You should be able to use your old files just as before with this update, but be aware that you have to manually change the live-persistence.conf file, removing the quotes from the dot, since the initramfs will not modify it if it is already present.

evgeni commented 12 years ago

Yepp, that's exactly what I found after posting my last comment and chatting with @mika about that issue. Could you squash these two commits into one? I'll happily merge then :)

lukas227 commented 12 years ago

I tried to do that, I hope I did it right (not too much git experience)

evgeni commented 12 years ago

Looks good. Will include it as soon on my PC and not on my Android phone, the GitHub app ain't really good.

evgeni commented 12 years ago

"merged" as a patch: https://github.com/grml/live-boot-grml/commit/95fb70f1ac45cccc8db0ee62781954f78b0b064f

Thanks!