tried to fix persistence-media= problem (issue1177)

grml / live-boot-grml

GNU General Public License v3.0

10 stars 11 forks source link

tried to fix persistence-media= problem (issue1177) #2

Closed lukas227 closed 11 years ago

lukas227 commented 11 years ago

< does not match a word that begins with a / such as device names
the logic of the if query to determine if a device is blacklist needs brackets (this is unrelated to issue1177): IF device is blacklisted OR (whitelist exists AND device is not whitelisted) See http://bts.grml.org/grml/issue1177

evgeni commented 11 years ago

I think the first part was fixed upstream in http://live.debian.net/gitweb/?p=live-boot.git;a=commit;h=acd782e4, could you test this as soon we have dailys built with the new live-boot code.

The second is (IMHO) just readability, as AND should already bind more than OR. Correct?

lukas227 commented 11 years ago

As for the first part: the new list handling looks fine to me and should work.

As for the second part: From 'man bash': AND and OR lists are sequences of one of more pipelines separated by the && and || control operators, respectively. AND and OR lists are executed with left associativity.

Just double checked in my bash: $ true || false && false $ echo $? 1

$ true || (false && false) $ echo $? 0

dash behaves just the same way.

evgeni commented 11 years ago

Charles writes on grml-devel that this is fixed, so I'd close the pull request? http://ml.grml.org/pipermail/grml-devel/2012-December/000269.html

lukas227 commented 11 years ago

sure.