grml / live-boot-grml

GNU General Public License v3.0
10 stars 12 forks source link

Allow +2 nameserver entries for dns= boot option #4

Closed lvdh closed 9 years ago

lvdh commented 9 years ago

Would this change be sufficient to allow more than two nameservers to be entered at live boot? (using the 'dns' boot option)

Apologies for my ignorance if more changes are necessary to solve this problem. Any pointers in the right direction are very welcome, I'm more than happy to learn.

For reference, this has been discussed in issue 1234: http://bts.grml.org/grml/issue1234

lvdh commented 9 years ago

FYI, make test does not show any possible problems for the affected files;

[live-boot-grml]$ make test
Checking for syntax errors......................... done.
Checking for bashisms.........possible bashism in components/9990-aaa-fixme.sh line 13 (HOST(TYPE|NAME)=):
HOSTNAME="host"
.....possible bashism in components/9990-misc-helpers.sh line 624 (read with option other than -r):
                    read -s passphrase
possible bashism in components/9990-misc-helpers.sh line 1319 (ulimit):
            ( sysctl -w fs.file-max=391524 ; ulimit -HSn 16384
...possible bashism in components/9990-mount-iscsi.sh line 39 (echo -e):
            echo -ne $i\\r
....possible bashism in components/9990-networking.sh line 132 ($HOST(TYPE|NAME)):
        OLDHOSTNAME=${HOSTNAME}
possible bashism in components/9990-networking.sh line 136 ($HOST(TYPE|NAME)):
        [ -z ${HOSTNAME} ] && HOSTNAME=${OLDHOSTNAME}
possible bashism in components/9990-networking.sh line 136 (HOST(TYPE|NAME)=):
        [ -z ${HOSTNAME} ] && HOSTNAME=${OLDHOSTNAME}
.... done.
[live-boot-grml]$ 
evgeni commented 9 years ago

Thanks, marged in 5eb34d46fe13b8511d6aef4cc28089db48612322