Any plan to finish this?

[dthree]

Hey, this is an awesome project!

I'm considering the use of this in Vorpal / Cash, however this would involve fine-tuning and perfecting its use.

I noticed you haven't committed anything in over a year. Do you have any plans on picking this project back up, or should I consider it dropped?

Thanks.

[piranna]

Hi @dthree, I was thinking about working on a fork of this project just to add the missing parts, if you want we could both work on it, how do you feel?

[dthree]

Sure! :+1:

---

I intend to write a full bash interpreter for JS, which would be used in Vorpal and Cash. This project would be a dependency of that.

Would you mind if I added you as a full member to the cash organization, and we named the repo as cash/bash-parser? I intend the full bash interpreter to be named cash/bash, and so this would make things semantically clear.

[piranna]

Could you be able to review how to modify the grammar? I'm somewhat urgent to have support for >|... :-/

[piranna]

(Urgent because it's the only missing redirection, no more...)

[dthree]

I have to dive into pegjs, I've never used it (I'm sure you're at the same point). But will do so soon!

[piranna]

:+1:

[dthree]

@piranna if you could join this chat on this matter that would be great:

https://gitter.im/dthree/cash

[grncdr]

so the answer to this question is a solid "maybe, but pull-requests are very welcome, if it's not moving fast enough feel free to fork"

[grncdr]

To further clarify, since I just got an email asking what's going on.

I didn't plan on finishing this, and until @parro-it mentioned me on https://github.com/sindresorhus/module-requests/issues/61 I hadn't noticed this issue. In the course of reviewing the code to bring @dthree up to speed I started cleaning up a few of the nastier parts. Then @forivall sent PR #13 with a bunch of test fixtures, and since I was already cleaning up some messy bits I thought I'd implement "just one more thing" :wink:

In any case, I don't think it's a great idea for the community at large to rely on me completing this library myself. There are currently 84 unparseable test cases from shellcheck, and probably some incorrect parses in the ones that don't fail outright. It's very unlikely I'll get that down to zero before getting busy with real-life again, so there's plenty of opportunity to contribute fixes & improvements.

I'm also serious about advising others on how to work with PEG.js & this grammar in particular. My offer to @dthree is open to anybody else who's interested. I'll also gladly add anybody as a collaborator to this repo, but only after they send a PR; This project has been around for over 2 years, and @forivall's is the only pull-request it's ever received.

So that's my position, I'm excited there's other people who want this finished and are willing to put in the work to make it happen. We can do it here or you can fork it and handle it how you prefer.

[dthree]

@grncdr Thanks and very appreciated!

I'm honestly not very set up to do a hangout, but if I figure that out I'll let you know!

---

I don't mind keeping the repo here and using it as a dep, it's either or to me. I was just earlier worried that you were long-gone from OSS and so we wouldn't be able to get PRs merged or something.

[grncdr]

It's probably most sensible for you to continue in your fork, I won't be spending a lot of time on this library going forward but I'll try to be available to answer questions

[dthree]

Okay thanks for all your help!