search

grncdr / merge-stream

Merge multiple streams into one interleaved stream
MIT License
214 stars 16 forks source link

Test on 'iojs' and '0.12' #16

Closed stevemao closed 9 years ago

shinnn commented 9 years ago

+1

stevemao commented 9 years ago

The current one is wrong. 0.10 means your testing on 0.1. You need to quote it to test on '0.10'.

grncdr commented 9 years ago

sorry I didn't see this one, can you please rebase?

grncdr commented 9 years ago

@shinnn feel free to merge this yourself as well :smile:

stevemao commented 9 years ago

rebased

shinnn commented 9 years ago

I prefer node rather than 0.12.

http://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Choosing-Node-versions-to-test-against

Specifying node or stable will run using the latest stable Node.js release

stevemao commented 9 years ago

better?

shinnn commented 9 years ago

Single quotes, please.

stevemao commented 9 years ago

done. i was trying to do minimum changes :)

shinnn commented 9 years ago

Ah, sorry I didn't check the existing style. Merging this anyway.

shinnn commented 9 years ago

@stevemao Thanks!

stevemao commented 9 years ago

Thanks. Can you make a release?

shinnn commented 9 years ago

I'm considering whether 0.2.0 or 1.0.0.

I'd like to hear your opinion, @grncdr.

stevemao commented 9 years ago

I think 1.0.0 should be fine :)

grncdr commented 9 years ago

If there's no API change, I'd say let's do 0.1.9 and 1.0.0. 0.1.9 so that users of semver ranges get it, and 1.0.0 because this module is actually pretty stable and in wide use.

stevemao commented 9 years ago

@grncdr because it switches from stream2 to 3 so you should at least do a minor release :)

stevemao commented 9 years ago

Also we added isEmpty (will probably be replaced #21) so there is an enhancement.

grncdr commented 9 years ago

@grncdr because it switches from stream2 to 3 so you should at least do a minor release :)

I definitely don't see the point in doing a 0.2.0, there's no need to bump minor for an enhancement pre 1.0.0. If the switch to streams3 changes the behaviour in a way that can be observed by users then 1.0.0 makes the most sense to me.