search

grncdr / merge-stream

Merge multiple streams into one interleaved stream
MIT License
214 stars 16 forks source link

Switch from Streams2 to Streams3 #19

Closed shinnn closed 9 years ago

shinnn commented 9 years ago

The current latest version of merge-stream uses Streams2 via the through2 module but Streams2 is an older implementation.

This PR replaces through2 v0.6 with readable-stream v2.0.0 to switch to Streams3 which is a more popular stream implementation as it's used in the latest Node and io.js.

shinnn commented 9 years ago

@grncdr What do you think?

grncdr commented 9 years ago

Looks great! I've also made you a collaborator on this repo and an owner of the package on npm so feel free to update things as you see fit :+1:

shinnn commented 9 years ago

@grncdr Thanks!

shinnn commented 9 years ago

@grncdr, how about adding @stevemao to this project, too? He've done great works in various projects, including this one.

stevemao commented 9 years ago

Thanks @shinnn , I'm happy to contribute :)

grncdr commented 9 years ago

@stevemao you've been added as a collaborator on github. I don't know your npm username but @shinnn can also add you as an owner with npm owner add <username> merge-stream

shinnn commented 9 years ago

:+1:

stevemao commented 9 years ago

Thanks @grncdr