search

grncdr / merge-stream

Merge multiple streams into one interleaved stream
MIT License
214 stars 16 forks source link

Propagate source stream errors through output #25

Closed FredKSchott closed 7 years ago

FredKSchott commented 7 years ago

Fixes #24

stevemao commented 7 years ago

@shinnn @grncdr

@FredKSchott presented a convincing argument. I think this is the right behaviour :)

FredKSchott commented 7 years ago

No problem, Thanks for the quick response!

Test added

stevemao commented 7 years ago

ping @shinnn, could you merge this and make a new release :) if you are too busy, can you add me to the npm package? Thanks.

shinnn commented 7 years ago

Strictly speaking, this change requires major version bump ("1.0.0" → "2.0.0"). But it can be also said that this PR is just a bug fix.

@stevemao @FredKSchott I'd like to hear your opinion.

stevemao commented 7 years ago

I think this is a bug fix.

shinnn commented 7 years ago

Published v1.0.1 to npm.

can you add me to the npm package?

@stevemao ✨ 

$ npm owner add stevemao merge-stream
+ stevemao (merge-stream)

$ npm owner ls merge-stream
grncdr <glurgle@gmail.com>
shinnn <snnskwtnb@gmail.com>
stevemao <maochenyan@gmail.com>
stevemao commented 7 years ago

Cheers man ⭐️

FredKSchott commented 7 years ago

Thanks everyone! Looking forward to using this