grndctrl / zed-gdscript

Zed support for the GDScript language
MIT License
9 stars 3 forks source link

LSP Support #2

Closed moomerman closed 2 months ago

moomerman commented 2 months ago

This adds a simple LSP integration using nc (necat) which is the same method I use to connect the helix editor to the Godot LSP.

It makes the following assumptions (which could be improved):

Screenshots

image

image

grndctrl commented 2 months ago

This adds a simple LSP integration using nc (necat) which is the same method I use to connect the helix editor to the Godot LSP.

@moomerman How would I test this locally?

moomerman commented 2 months ago

@moomerman How would I test this locally?

You can go to zed extensions with cmd-shift-p and search for extensions. Then Install Dev Extension and choose the folder.

grndctrl commented 2 months ago

You can go to zed extensions with cmd-shift-p and search for extensions. Then Install Dev Extension and choose the folder.

This doesn't appear to be doing anything. Do I need to build it first?

moomerman commented 2 months ago

This doesn't appear to be doing anything. Do I need to build it first?

Hmm odd. It automatically builds it when I add it, did you remove the other version of the extension? I'm on Zed Preview, maybe that has some support that hasn't been merged into stable yet?

grndctrl commented 2 months ago

Hmm odd. It automatically builds it when I add it, did you remove the other version of the extension? I'm on Zed Preview, maybe that has some support that hasn't been merged into stable yet?

My bad, had rust installed, not rustup. I'm on a new mac since I wrote the original extension. LSP works great, thanks again.

grndctrl commented 2 months ago

I opened a PR yesterday, but a check fails. https://github.com/zed-industries/extensions/pull/594

moomerman commented 2 months ago

I opened a PR yesterday, but a check fails. zed-industries/extensions#594

I've opened a new PR that fixes the tags query 🙏🏼

grndctrl commented 2 months ago

@moomerman to the rescue, at this point I'm thinking maybe I should just handover the whole repo to you...