grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 22 forks source link

Fix timestamp handling in instxml and in data manipulation #105

Closed vladimir-mencl-eresearch closed 2 months ago

vladimir-mencl-eresearch commented 2 months ago

Fix pending issues identified in #92 ( this comment ) to avoid eDB ignoring updates to Institution or Realm data because ts has not changed:

(1) For an Institution, where InstServer and ServiceLoc objects track their own timestamps, return institution ts as maximum over ts of institution itself and its subordinate objects.

(2) In data manipulation of subordinate objects included in the export, update Institution ts whenever a subordinate object is added, updated or deleted.

vladimir-mencl-eresearch commented 2 months ago

I have tested this carefully and it solves the issues with CAT eDB updates.

@zmousm , @ghalse , any comments on this? OK to merge?

ghalse commented 2 months ago

I've had a quick look through it, and it seems to make sense. But I'm not going to get a chance to properly test it for some time :(

vladimir-mencl-eresearch commented 2 months ago

Thanks @ghalse !

Has been now running in PROD at member.eduroam.net.nz for a week - with eDB ingesting the feed and timestamps being updated.