grnet / djnro

DjNRO hits the decks of eduroam database management
http://djnro.grnet.gr/
Other
10 stars 21 forks source link

Django 1.11 - another upgrade to LTS Django #56

Closed vladimir-mencl-eresearch closed 5 years ago

vladimir-mencl-eresearch commented 6 years ago

Hi @zmousm ,

Time flies fast - Django 1.8 went EOL this April, so I've done upgrade to the next LTS - which is Django 1.11.

This time, it wasn't as disruptive as before.

Can you please have a look and merge?

Thanks a lot in advance!

Cheers, Vlad

vladimir-mencl-eresearch commented 5 years ago

I've just rebased on master and resolved conflicts (in edumanage/views.py - conflicting with ab6d29a

vladimir-mencl-eresearch commented 5 years ago

Hi @zmousm, documentation added - now over to you for review.

cangus commented 5 years ago

Looks clean to me, a couple of tiny things mentioned above.

cangus commented 5 years ago

All comments have been addressed - looks good to merge